Skip to content

keys can be set as array#135

Merged
glynnbird merged 1 commit intoapache:masterfrom
mlecoq:feature/keysAsArray
Dec 17, 2018
Merged

keys can be set as array#135
glynnbird merged 1 commit intoapache:masterfrom
mlecoq:feature/keysAsArray

Conversation

@mlecoq
Copy link
Copy Markdown
Contributor

@mlecoq mlecoq commented Nov 22, 2018

Hi,

just a small change, in the types there is the following line:
// Return only documents that match the specified keys. keys?: string; // This can be string[] too ???

In js, we pass keys as array so we should be able to do it in TypeScript too

@mlecoq
Copy link
Copy Markdown
Contributor Author

mlecoq commented Dec 16, 2018

@glynnbird sorry to bother you, I am waiting for this pull request since my query cannot be performed with key as string. When do you think It can be embedded (I can modify it if needed) ?

Thank you very much

@glynnbird glynnbird merged commit d34edb8 into apache:master Dec 17, 2018
@glynnbird
Copy link
Copy Markdown
Contributor

Thanks for the correction @mlecoq. It's now in the master branch and will get released in due course.

@mlecoq
Copy link
Copy Markdown
Contributor Author

mlecoq commented Dec 17, 2018

Great ! Thank you 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants