Closed
Conversation
garrensmith
requested changes
Jul 4, 2017
Member
garrensmith
left a comment
garrensmith
left a comment
There was a problem hiding this comment.
This is a great start. Could you review your work against Cloudant's https://github.com/cloudant/nodejs-cloudant/blob/master/cloudant.js#L151-L169
Also could you add a test to prove this is working.
| } | ||
|
|
||
| function findDoc(query, callback) { | ||
| return relax({ db: dbName, path: '_find', method: 'POST', body: query }, callback); |
Member
There was a problem hiding this comment.
none of the other methods here do this at this point, I assume relax() does this already.
| session: session, | ||
| insert: insertDoc, | ||
| get: getDoc, | ||
| find: findDoc, |
Member
There was a problem hiding this comment.
Could you align this correctly.
Merged
Member
|
Great start, closing in favour of #50 which adds tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Added find to Nano. This way you can use custom queries.