Merged
Conversation
This is a simple version that goes along with the release artifacts file setup mostly, just adds a systemd unit file for nouveau. Nouveau config setting can be automatically enabled the rpm install using `COUCHDB_NOUVEAU_ENABLE=true`. For instance: `COUCHDB_NOUVEAU_ENABLE=true COUCHDB_COOKIE=c00kie dnf install couchdb*.rpm` Java dependency is declared as a `Suggests:...`. This is the weakest form of dependency declaration. It won't automatically bring in java 21. In the next minor version it may become a `Recommends:` which is one level higher and will automatically install it. If nouveau config is enabled during the RPM install, user is then urged to install java (suggestion via dnf but they may install their own from any vendor) and to enable the systemd unit to auto-start after boot. CouchDB service also works this way: it has to be enabled explicitly. This part didn't change: `systemctl enable couchdb` `systemctl enable couchdb-nouveau` This lets a user choose to start just CouchDB on a server, just Nouveau, or both CouchDB and Noveau. In addition, since we're updating the RPM package, remove some of deprecated/redundant settings needed for old CentOS-es: - Log to journald instead of a file - Log level is already set to info, so no need to override it again in the RPM package - No need for an init file, all supported OSes have systemd
Contributor
Author
|
When enabling nouveau with the environmental variable the successful install should look something like: |
big-r81
reviewed
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple version that goes along with the release artifacts file setup mostly, just adds a systemd unit file for nouveau.
Nouveau config setting can be automatically enabled during the rpm install using
COUCHDB_NOUVEAU_ENABLE=true.For instance:
COUCHDB_NOUVEAU_ENABLE=true COUCHDB_COOKIE=c00kie dnf install couchdb*.rpmJava dependency is declared as a
Suggests:.... This is the weakest form of dependency declaration. It won't automatically bring in java 21.In the next minor version it may become a
Recommends:which is one level higher and will automatically install it.If nouveau config is enabled during the RPM install, user is then urged to install java (suggestion via dnf but they may install their own from any vendor) and to enable the systemd unit to auto-start after boot.
CouchDB service also works this way: it has to be enabled explicitly. This part didn't change:
systemctl enable couchdbsystemctl enable couchdb-nouveauThis lets a user choose to start just CouchDB on a server, just Nouveau, or both CouchDB and Noveau.
In addition, since we're updating the RPM package, remove some of deprecated/redundant settings needed for old CentOS-es: