Skip to content

Ensure nouveau jar files are owned by root#155

Merged
rnewson merged 1 commit intoapache:mainfrom
martiell:install-nouveau-as-root
Sep 18, 2024
Merged

Ensure nouveau jar files are owned by root#155
rnewson merged 1 commit intoapache:mainfrom
martiell:install-nouveau-as-root

Conversation

@martiell
Copy link
Contributor

Remove the nouveau jar files from the list of files to have their ownership and group changed in the couchdb-nouveau postinst script. These files are not expected to change at runtime, and the service should not have permission to overwrite them.

Overview

The installed jar files should be owned as root to prevent them being overwritten, replaced or deleted accidentally, or maliciously in the event of a vulnerability in the service or its dependencies.

Testing recommendations

Build and install packages with this change, observing that /opt/nouveau/lib and files within are owned by root.
The service should still operate correctly.

GitHub issue number

n/a

Related Pull Requests

none

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

Remove the nouveau jar files from the list of files to have their
ownership and group changed in the couchdb-nouveau postinst script.
These files are not expected to change at runtime, and the service
should not have permission to overwrite them.
@rnewson
Copy link
Member

rnewson commented Sep 18, 2024

the sandboxing in the service file (ReadWritePaths=/var/lib/nouveau) covers this, but it doesn't hurt to use file ownership also.

@rnewson rnewson self-requested a review September 18, 2024 09:17
@rnewson rnewson merged commit 9f128cf into apache:main Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants