Skip to content

Running elixir test suite fails on credo #1801

@van-mronov

Description

@van-mronov

Expected Behavior

make elixir should run elixir tests

Current Behavior

$ make elixir
Resolving Hex dependencies...
Dependency resolution completed:
Unchanged:
  bunt 0.2.0
  credo 1.0.0
  httpotion 3.1.0
  ibrowse 4.4.1
  jason 1.1.2
  jiffy 0.15.2
All dependencies up to date
Checking 21 source files ...

  Software Design
┃
┃ [D] → Found a TODO tag in a comment: # TODO: port sever_port tests from
┃       config.js
┃       test/config_test.exs:73 #(ConfigTest.delete_config)
┃ [D] → Found a TODO tag in a comment: # TODO: In JS we re-fetch _changes with
┃       since_seq, is that
┃       test/replication_test.exs:587 #(ReplicationTest.run_since_seq_repl)
┃ [D] → Found a TODO tag in a comment: # TODO: Parameterize these
┃       test/replication_test.exs:9 #(ReplicationTest)
┃ [D] → Found a TODO tag in a comment: # TODO: switch this to _local when that's
┃       landed
┃       test/config_test.exs:12 #(ConfigTest)
┃ [D] → Found a TODO tag in a comment: # TODO: port remainder of
┃       security_validation.js suite
┃       test/security_validation_test.exs:205 #(SecurityValidationTest)
┃  ...  (5 more, use `-a` to show them)

  Code Readability
┃
┃ [R] → Modules should have a @moduledoc tag.
┃       lib/couch/db_test.ex:1:11 #(Couch.DBTest)
┃ [R] → Modules should have a @moduledoc tag.
┃       test/support/couch_test_case.ex:1:11 #(CouchTestCase)

Please report incorrect results: https://github.com/rrrene/credo/issues

Analysis took 3.8 seconds (0.04s to load, 3.8s running checks)
126 mods/funs, found 2 code readability issues, 10 software design suggestions.

Showing priority issues: ↑ ↗ →  (use `--strict` to show all issues, `--help` for options).
make: *** [elixir-credo] Error 4

Possible Solution

add moduledoc attributes in Couch.DBTest and CouchTestCase

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions