Skip to content

Set eunit timeout on a whole test object#1123

Merged
eiri merged 1 commit intomasterfrom
fix-create_delete_database_continuously-test
Jan 23, 2018
Merged

Set eunit timeout on a whole test object#1123
eiri merged 1 commit intomasterfrom
fix-create_delete_database_continuously-test

Conversation

@eiri
Copy link
Copy Markdown
Member

@eiri eiri commented Jan 22, 2018

Overview

I've accidentally overrode custom 2 mins timeout for should_create_delete_database_continuously tests to default 5 sec with?_test wrapper. It went unnoticed in local tests and travis, since in general "should_create_delete_database_continuously (100 times)" passes within 1.096s, but Jenkins prove to be more sensitive.

Testing recommendations

Standard make eunit apps=couch should pass. More importantly Jenkins now should not throw timeout on this test.

Related Issues or Pull Requests

Fixes: #1122

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

@eiri
Copy link
Copy Markdown
Member Author

eiri commented Jan 22, 2018

@wohali This should fix Jenkins, but I guess it needs to hit "master" to confirm. Sorry about this mixup, the original test was kind of hard to untangle, that's mainly the reason I took on refactoring it.

Alternatively we can just remote this "100 times" run, honestly it doesn't really prove or demonstrate anything "10 times" run doesn't show.

@wohali
Copy link
Copy Markdown
Member

wohali commented Jan 22, 2018

Nice, looks good. +1

If you want to also remove the 100x test, go for it.

@eiri eiri merged commit b2e0e13 into master Jan 23, 2018
@eiri eiri deleted the fix-create_delete_database_continuously-test branch January 23, 2018 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants