Merged
Conversation
Member
Author
|
@wohali This should fix Jenkins, but I guess it needs to hit "master" to confirm. Sorry about this mixup, the original test was kind of hard to untangle, that's mainly the reason I took on refactoring it. Alternatively we can just remote this "100 times" run, honestly it doesn't really prove or demonstrate anything "10 times" run doesn't show. |
nickva
approved these changes
Jan 22, 2018
Member
|
Nice, looks good. +1 If you want to also remove the 100x test, go for it. |
wohali
approved these changes
Jan 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
I've accidentally overrode custom 2 mins timeout for
should_create_delete_database_continuouslytests to default 5 sec with?_testwrapper. It went unnoticed in local tests and travis, since in general "should_create_delete_database_continuously (100 times)" passes within 1.096s, but Jenkins prove to be more sensitive.Testing recommendations
Standard
make eunit apps=couchshould pass. More importantly Jenkins now should not throw timeout on this test.Related Issues or Pull Requests
Fixes: #1122
Checklist