Skip to content

Remove _config call in couch_peruser_test#1130

Merged
jiangphcn merged 1 commit intoapache:masterfrom
cloudant:issue-876-remove-_config-call-in-eunit-test
Mar 23, 2018
Merged

Remove _config call in couch_peruser_test#1130
jiangphcn merged 1 commit intoapache:masterfrom
cloudant:issue-876-remove-_config-call-in-eunit-test

Conversation

@jiangphcn
Copy link
Contributor

Overview

Replaced the /_config endpoint call using config:set() in the set_config() call to be more sure about configuration changes.

#1068 (review)

Testing recommendations

make check skip_deps+=couch_epi apps=couch_peruser

======================== EUnit ========================
module 'couch_peruser_app'
module 'couch_peruser_sup'
module 'couch_peruser_test'
  couch_peruser test
Application crypto was left running!
    couch_peruser_test:162: should_create_anon_user_db_with_default...[0.002 s] ok
    couch_peruser_test:163: should_create_anon_user_db_with_default...ok
    couch_peruser_test:152: should_create_user_db_with_default...[0.002 s] ok
    couch_peruser_test:153: should_create_user_db_with_default...ok
    couch_peruser_test:175: should_create_user_db_with_q4...[0.002 s] ok
    couch_peruser_test:176: should_create_user_db_with_q4...ok
    couch_peruser_test:187: should_create_anon_user_db_with_q4...[0.002 s] ok
    couch_peruser_test:188: should_create_anon_user_db_with_q4...ok
    couch_peruser_test:200: should_not_delete_user_db...ok
    couch_peruser_test:200: should_not_delete_user_db...ok
    couch_peruser_test:212: should_delete_user_db...ok
    couch_peruser_test:212: should_delete_user_db...ok
    couch_peruser_test:243: should_reflect_config_changes...ok
    couch_peruser_test:244: should_reflect_config_changes...ok
    couch_peruser_test:245: should_reflect_config_changes...ok
    couch_peruser_test:246: should_reflect_config_changes...ok
    couch_peruser_test:247: should_reflect_config_changes...ok
    couch_peruser_test:248: should_reflect_config_changes...ok
    couch_peruser_test:257: should_add_user_to_db_admins...[0.001 s] ok
    couch_peruser_test:266: should_add_user_to_db_members...[0.001 s] ok
    couch_peruser_test:285: should_not_remove_existing_db_admins...ok
    couch_peruser_test:286: should_not_remove_existing_db_admins...ok
    couch_peruser_test:287: should_not_remove_existing_db_admins...ok
    couch_peruser_test:305: should_not_remove_existing_db_members...ok
    couch_peruser_test:306: should_not_remove_existing_db_members...ok
    couch_peruser_test:307: should_not_remove_existing_db_members...ok
    couch_peruser_test:336: should_remove_user_from_db_admins...ok
    couch_peruser_test:337: should_remove_user_from_db_admins...ok
    couch_peruser_test:338: should_remove_user_from_db_admins...ok
    couch_peruser_test:339: should_remove_user_from_db_admins...ok
    couch_peruser_test:340: should_remove_user_from_db_admins...ok
    couch_peruser_test:341: should_remove_user_from_db_admins...ok
    couch_peruser_test:370: should_remove_user_from_db_members...ok
    couch_peruser_test:371: should_remove_user_from_db_members...ok
    couch_peruser_test:372: should_remove_user_from_db_members...ok
    couch_peruser_test:373: should_remove_user_from_db_members...ok
    couch_peruser_test:374: should_remove_user_from_db_members...ok
    couch_peruser_test:375: should_remove_user_from_db_members...ok
[os_mon] cpu supervisor port (cpu_sup): Erlang has closed
    [done in 41.180 s]
  [done in 42.834 s]
module 'couch_peruser'
=======================================================
  All 38 tests passed.

Related Issues or Pull Requests

issue #876

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

@jiangphcn jiangphcn force-pushed the issue-876-remove-_config-call-in-eunit-test branch 9 times, most recently from 5c7ae0a to c8eb01c Compare January 29, 2018 08:10
@jiangphcn
Copy link
Contributor Author

Can somebody help review this PR, thanks?

Copy link
Member

@eiri eiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jiangphcn jiangphcn force-pushed the issue-876-remove-_config-call-in-eunit-test branch from c8eb01c to 95a78ce Compare March 22, 2018 14:46
@jiangphcn jiangphcn merged commit a0c863d into apache:master Mar 23, 2018
@jiangphcn jiangphcn deleted the issue-876-remove-_config-call-in-eunit-test branch March 23, 2018 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants