Skip to content

add test covering loading admins from config#1249

Merged
janl merged 2 commits intoapache:masterfrom
janl:test/config-admins-auth-cache
Mar 28, 2018
Merged

add test covering loading admins from config#1249
janl merged 2 commits intoapache:masterfrom
janl:test/config-admins-auth-cache

Conversation

@janl
Copy link
Copy Markdown
Member

@janl janl commented Mar 28, 2018

No description provided.

@janl
Copy link
Copy Markdown
Member Author

janl commented Mar 28, 2018

Travis suggests this new test is flakey.

Is config:set() async? e.g. can there be no admin configured if trying to config:get() right after?

@janl janl force-pushed the test/config-admins-auth-cache branch from 4e7df6f to ba1eb32 Compare March 28, 2018 13:25
@janl
Copy link
Copy Markdown
Member Author

janl commented Mar 28, 2018

new patch with proper wait

@janl janl added this to the 2.2.0 milestone Mar 28, 2018
@eiri
Copy link
Copy Markdown
Member

eiri commented Mar 28, 2018

This should do it, I think. For a reason why this needed - config:set is sync, but config change broadcasting and consequently pass hashing isn't, so half of time get_admin/1 in couch_auth cache will be getting "password" instead of prefixed hash and default to nil

@janl janl merged commit f6fc285 into apache:master Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants