removing HTML comments from JST templates#126
Closed
BigBlueHat wants to merge 1 commit intoapache:masterfrom
Closed
removing HTML comments from JST templates#126BigBlueHat wants to merge 1 commit intoapache:masterfrom
BigBlueHat wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
Hey @BigBlueHat, this is a great idea. Unfortunately it doesn't seem to work. It seems to completely remove all template data. I ran Let me know if I can help. |
This lightens templates.js by removing HTML comments from the templates.
Member
Author
|
@garrensmith seems I'd left out a return... :-P |
Member
|
Great. Works nicely. I've merged it in. You can close the pull request. |
Member
Author
|
Thanks, @garrensmith! |
cararemixed
pushed a commit
to cararemixed/couchdb
that referenced
this pull request
Dec 10, 2014
This closes apache#126 Conflicts: readme.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lightens templates.js by removing HTML
comments from the templates.
@deathbearbrown @garrentsmith just some scrubbing.