[3/5] Clustered Purge - Rewrite pluggable storage engine tests #1368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 1, 2018
nickva
approved these changes
Jun 1, 2018
iilyak
reviewed
Jun 20, 2018
| ok = couch_server:delete(couch_db:name(Db), []). | ||
|
|
||
|
|
||
| cpse_read_empty_docs(Db) -> |
Contributor
There was a problem hiding this comment.
Name of the test is misleading. For some reason I read the test name as "Read documents which are empty". It could be just me though.
cpse_read_missing_docs or cpse_read_non_existent_docs would be better IMO.
Contributor
There was a problem hiding this comment.
cpse_read_docs_from_empty_db is also an option.
Contributor
There was a problem hiding this comment.
Renamed to cpse_read_docs_from_empty_db/1
iilyak
reviewed
Jun 20, 2018
| ?assertEqual(?NUM_CLIENTS + 2, length(Pids1)), | ||
| Pids1 = couch_db_engine:monitored_by(Db), | ||
| % +3 for self, db pid, and process tracker | ||
| ?assertEqual(?NUM_CLIENTS + 3, length(Pids1)), |
Contributor
There was a problem hiding this comment.
We could use couch_db:monitored_by/1, which would remove db and process tracker. However we probably want to limit functions we use to couch_db_engine module. I am really not sure which approach is better. Just wanted to mention it so I don't forget why I stopped here.
davisp
force-pushed
the
COUCHDB-3326-clustered-purge-pr3-refactor-pse-tests
branch
from
e2bbbf0 to
826b17e
Compare
jiangphcn
force-pushed
the
COUCHDB-3326-clustered-purge-pr2-simplify-mem3-rep
branch
2 times, most recently
from
8cbf976 to
966497c
Compare
jiangphcn
force-pushed
the
COUCHDB-3326-clustered-purge-pr3-refactor-pse-tests
branch
from
826b17e to
163b02e
Compare
jiangphcn
force-pushed
the
COUCHDB-3326-clustered-purge-pr2-simplify-mem3-rep
branch
from
966497c to
b663478
Compare
jiangphcn
force-pushed
the
COUCHDB-3326-clustered-purge-pr3-refactor-pse-tests
branch
from
6a370e6 to
bff390d
Compare
Member
Author
|
+1 but squerge that merge conflict to the commit it goes in. |
jiangphcn
force-pushed
the
COUCHDB-3326-clustered-purge-pr2-simplify-mem3-rep
branch
from
b663478 to
da43788
Compare
jiangphcn
force-pushed
the
COUCHDB-3326-clustered-purge-pr3-refactor-pse-tests
branch
from
bff390d to
4c87d78
Compare
Contributor
|
Thanks @davisp I already squashed that merge conflict to the commit it goes in. |
davisp
force-pushed
the
COUCHDB-3326-clustered-purge-pr2-simplify-mem3-rep
branch
from
169e84c to
391d7b5
Compare
jiangphcn
changed the base branch from
COUCHDB-3326-clustered-purge-pr2-simplify-mem3-rep
to
master
It turns out that if any storage engine has to open itself during a callback it would end up violating the guarantee of a single writer. This change in the test suite changes things to use couch_server so that storage engines are now free to do as they want reopening themselves.
jiangphcn
force-pushed
the
COUCHDB-3326-clustered-purge-pr3-refactor-pse-tests
branch
from
4c87d78 to
e0c7ad3
Compare
nickva
deleted the
COUCHDB-3326-clustered-purge-pr3-refactor-pse-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the pluggable storage engine test suite so that its a self contained app to clean up code and various other odds and ends.
The biggest change is that this also makes the tests go through couch_server instead of instantiating the engines directly. This allows a storage engine to open itself as a database which turned out to be necessary for compactions with purge so that we can enable code re-use without requiring every engine to correctly implement the get_minimum_purge_seq logic.
This PR depends on #1366 and #1367.