Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement couch_file:format_status to log filepath #1601
Erlang OTP logs the fact when gen_server behavior crashes. However in case of couch_file the filename is not part of the state. So it is quite hard to figure out what happened given the current log entry format. This PR adds information about filepath to the log entry. Keep in mind though that the filepath value is captured on couch_file:start_link. It is not representing the current file name if file is renamed or moved.
Related Issues or Pull Requests
This is a port of PR from apache/couchdb-couch#215 to couchdb repository.
Sep 12, 2018
1 check passed
@iilyak Personally I prefer atoms for both
But to be clear I didn't try to twist your arm here, it's obviously a question of personal preferences, I was just was surprised when I was walking through commits happened while I was away.
@eiri: Here is an extract from [
I remember being inspired by the following example from OTP
The use of the function in otp is inconsistent:
My guess is it might have to do with the way how observer or SASL uses this data. Since we are not using either we should be able to use any format we want.
Huh. I haven't seen this
To be honest I feel very confused on what OTP folks are doing here in source code, mixing strings, atoms, camelcase and capitalized spaced. Dunno, maybe it just me.
Anyway, I take my complaints back, since you are following worded OTP recommendation here let's keep it this way, sorry about whole confusion.