Skip to content

Partition feature flag#1684

Merged
garrensmith merged 2 commits intoapache:masterfrom
garrensmith:partition-feature-flag
Jan 22, 2019
Merged

Partition feature flag#1684
garrensmith merged 2 commits intoapache:masterfrom
garrensmith:partition-feature-flag

Conversation

@garrensmith
Copy link
Copy Markdown
Member

@garrensmith garrensmith commented Oct 26, 2018

Overview

Add partition feature flag based for #1789

Testing recommendations

Create something like this in local.ini:

[feature_flags]
partitions||* = false
partitions||allowed* = true

Then:
curl -X PUT http://localhost:5984/not-allowed?partitioned=true should throw an error
curl -X PUT http://localhost:5984/allowed-partition?partitioned=true should be created

Related Issues or Pull Requests

#1789

Checklist

  • Code is written and works correctly;
  • Tests

@garrensmith garrensmith changed the base branch from partition-review-fixes to feature/database-partitions January 15, 2019 13:14
Copy link
Copy Markdown
Contributor

@iilyak iilyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davisp davisp force-pushed the feature/database-partitions branch 8 times, most recently from 8cd68be to 91af772 Compare January 18, 2019 18:35
@davisp davisp closed this Jan 18, 2019
@davisp davisp changed the base branch from feature/database-partitions to master January 18, 2019 21:25
@davisp davisp reopened this Jan 18, 2019
@davisp
Copy link
Copy Markdown
Member

davisp commented Jan 18, 2019

Whoops. PRs into PRs are weird.

@garrensmith garrensmith merged commit 00ce1c1 into apache:master Jan 22, 2019
@garrensmith garrensmith deleted the partition-feature-flag branch December 12, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants