Conversation
This was referenced Dec 6, 2018
davisp
force-pushed
the
fix-get-minimum-purge-seq
branch
from
27f054b to
2d02d73
Compare
Contributor
|
+1 |
eiri
reviewed
Dec 6, 2018
davisp
force-pushed
the
fix-get-minimum-purge-seq
branch
from
2d02d73 to
8d94b20
Compare
eiri
approved these changes
Dec 6, 2018
Member
eiri
left a comment
eiri
left a comment
There was a problem hiding this comment.
A couple of nibs, but all non material. +1
Contributor
|
All tests passing for me with from presumably flaky JS test. |
Member
Contributor
|
+1 |
davisp
force-pushed
the
fix-get-minimum-purge-seq
branch
2 times, most recently
from
304ede7 to
4da5dd4
Compare
This adds an API call for looking up a single design doc regardless of whether the database is clustered or not.
The underlying clustered _all_docs call can cause significant extra load during compaction.
davisp
force-pushed
the
fix-get-minimum-purge-seq
branch
from
4da5dd4 to
0a2e8e8
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This fixes a silly mistake of using a clustered _all_docs lookup to get a single design document.
Testing recommendations
Code is covered by
make checkRelated Issues or Pull Requests
Clustered purge added the bad code.
Checklist