Skip to content

Re-Introduce cpse_test_purge_seqs#1831

Merged
jiangphcn merged 1 commit intomasterfrom
intro-cpse_test_purge_seqs
Jan 3, 2019
Merged

Re-Introduce cpse_test_purge_seqs#1831
jiangphcn merged 1 commit intomasterfrom
intro-cpse_test_purge_seqs

Conversation

@jiangphcn
Copy link
Contributor

Overview

Re-introduce cpse_test_purge_seqs after fixing issue on cpse_test_purge_seqs:cpse_increment_purge_seq_on_partial_purge/1 with undef issue.

      cpse_gather: make_test_fun (cpse_increment_purge_seq_on_partial_purge)...*failed*
in function cpse_util:save_doc/3
  called as save_doc(<<"db-475a26f2204d6b20d19fc5334d8f4adb">>,{[{'_id',foo},{vsn,2}]},[replicated_changes])
in call from cpse_test_purge_seqs:cpse_increment_purge_seq_on_partial_purge/1 (src/cpse_test_purge_seqs.erl, line 105)
**error:undef
  output:<<"">>

Testing recommendations

   cpse_test_purge_seqs
      cpse_gather: make_test_fun (cpse_increment_purge_seq_on_complete_purge)...[0.100 s] ok
      cpse_gather: make_test_fun (cpse_increment_purge_multiple_times)...[0.074 s] ok
      cpse_gather: make_test_fun (cpse_increment_purge_seq_on_partial_purge)...[0.080 s] ok
      [done in 0.377 s]

Related Issues or Pull Requests

#1798

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

Copy link
Contributor

@jaydoane jaydoane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

informal +1

  cpse_test_purge_seqs
    cpse_gather: make_test_fun (cpse_increment_purge_seq_on_complete_purge)...[0.035 s] ok
    cpse_gather: make_test_fun (cpse_increment_purge_multiple_times)...[0.025 s] ok
    cpse_gather: make_test_fun (cpse_increment_purge_seq_on_partial_purge)...[0.027 s] ok


-module(cpse_test_purge_seqs).
-compile(export_all).
-compile(nowarn_export_all).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind removing this line so that we don't have a merge conflict with #1798?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, remove this line using f2884b4

@jiangphcn jiangphcn force-pushed the intro-cpse_test_purge_seqs branch from c940e22 to f2884b4 Compare January 3, 2019 02:11
  - Re-introduce cpse_test_purge_seqs after fixing issue on
  cpse_test_purge_seqs:cpse_increment_purge_seq_on_partial_purge/1
  with undef issue
@jiangphcn jiangphcn force-pushed the intro-cpse_test_purge_seqs branch from f2884b4 to d12c22b Compare January 3, 2019 02:13
@jiangphcn jiangphcn merged commit dc93156 into master Jan 3, 2019
@jiangphcn jiangphcn deleted the intro-cpse_test_purge_seqs branch January 3, 2019 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments