Skip to content

test: run elixir tests, but down fail entire build if they fail#1907

Closed
janl wants to merge 1 commit intomasterfrom
feat/selective-elixir
Closed

test: run elixir tests, but down fail entire build if they fail#1907
janl wants to merge 1 commit intomasterfrom
feat/selective-elixir

Conversation

@janl
Copy link
Copy Markdown
Member

@janl janl commented Feb 6, 2019

My compromise suggestion for #1902

@eiri
Copy link
Copy Markdown
Member

eiri commented Feb 7, 2019

Failure in tests:

* test GET /dbname/_design_docs (565.1ms)

  1) test GET /dbname/_design_docs (PartitionDDocTest)
     test/partition_ddoc_test.exs:159
     Assertion with == failed
     code:  assert length(body["rows"]) == 1
     left:  0
     right: 1
     stacktrace:
       test/partition_ddoc_test.exs:168: (test)

and green Travis, so works as expected.

That'd be +1 from me to immediately unblock release pipe, but I think we need @wohali opinion on this as well.

@garrensmith
Copy link
Copy Markdown
Member

We can close this since the elixir tests are merged in

@wohali wohali deleted the feat/selective-elixir branch October 21, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants