Fauxton: make hidden tabs in _changes visible#200
Closed
robertkowalski wants to merge 1 commit intoapache:masterfrom
Closed
Fauxton: make hidden tabs in _changes visible#200robertkowalski wants to merge 1 commit intoapache:masterfrom
robertkowalski wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
So we shouldn't keep the tabs. A very old version of the design used the tabs and it's left over from back then. Right now, with them visible, that docs tab is redundant, it does the same as the Breadcrumb header. When doing the new design for _changes you can remove the tabs entirely or use a different layout in your routeObject that doesn't have tabs. |
robertkowalski
added a commit
to robertkowalski/couchdb
that referenced
this pull request
Mar 31, 2014
robertkowalski
added a commit
to robertkowalski/couchdb
that referenced
this pull request
Apr 1, 2014
robertkowalski
added a commit
to robertkowalski/couchdb
that referenced
this pull request
Apr 1, 2014
ksnavely
pushed a commit
to ksnavely/couchdb
that referenced
this pull request
May 1, 2014
robertkowalski
added a commit
to robertkowalski/couchdb
that referenced
this pull request
Jul 11, 2014
cararemixed
pushed a commit
to cararemixed/couchdb
that referenced
this pull request
Dec 9, 2014
Fix: correct lager startup in crash_log test
nickva
pushed a commit
to cloudant/couchdb
that referenced
this pull request
Apr 21, 2017
This closes apache#200 Signed-off-by: ILYA Khlopotov <iilyak@apache.org>
lag-linaro
pushed a commit
to lag-linaro/couchdb
that referenced
this pull request
Oct 25, 2018
bootstrap: avoid trying to run 'debug' command
janl
pushed a commit
that referenced
this pull request
Jan 5, 2020
nickva
pushed a commit
to nickva/couchdb
that referenced
this pull request
Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found some hidden tabs in the
_changes-screen I am working on, they are positioned behind the upper header with the breadcrumbs.I am not sure if we want them, but I made them visible so everybody can have a look.
I find the tabs very useful, but maybe they should be positioned
fixedso it's always in the screen and not just on scrolldown.Merge with caution: if it is planned that e.g.
Configwill get a fixed header like most views, the padding for tabs makes sense. If not and there would be tabs added, the tabs would have too much space to the top.