Skip to content

Remove log level name from the log list & some styling fixes#205

Closed
robertkowalski wants to merge 1 commit intoapache:masterfrom
robertkowalski:2135-remove-log-level
Closed

Remove log level name from the log list & some styling fixes#205
robertkowalski wants to merge 1 commit intoapache:masterfrom
robertkowalski:2135-remove-log-level

Conversation

@robertkowalski
Copy link
Member

  • Remove the message-level from the view
  • small columns (pid, date) get less width
  • padding around the view

Closes COUCHDB-2135

Preview:
bildschirmfoto 2014-04-11 um 21 58 32

- Remove the message-level from the view
- small columns (pid, date) get less width
- padding around the view

Closes COUCHDB-2135
@nomicode
Copy link
Contributor

Why would you remove log level?

@robertkowalski
Copy link
Member Author

You can see the level by the color, so it might be redundant and @kxepal wants to remove it to save some more space.

@wohali
Copy link
Member

wohali commented Apr 11, 2014

Lots of people are red-blue and red-green colour blind. -1.

@robertkowalski
Copy link
Member Author

I am not colorblind, but with text I can use ctrl+f to search for errors.

As I think there is some further discussion needed regarding that change I will slice off the style changes I made into a separate PR.

@nomicode
Copy link
Contributor

Look at how Trello solve the colour blindness thing. You can enable optional "textures".

@garrensmith
Copy link
Member

I would prefer to keep loglevel. You can then filter on it. I would move the filter to above the table so that we have more width. We could remove the PID, not sure how helpful that is.
I think it would be worthwhile to remove all the logs that are just this page querying logs. So anything thats /_logs.

@deathbearbrown
Copy link
Member

RE: colorblindness
When you do zebra striping it's better to do it by value than color (IE: dark and light) People can differentiate that better than by color. Those particular red/blue hexes are the same value. So if you can't see color, you'll see the same grey.

I like art stuff, and wanted to comment because I happen to know about this stuff. >.>

@wohali
Copy link
Member

wohali commented Apr 14, 2014

Sorry for the drive-by earlier.

I agree with @deathbearbrown and @garrensmith here. Filtering on log level is useful, and CTRL+F to search row by row on the actual log level itself is useful. I don't want to give up either of those things.

I'm neutral on styling preferences other than that we do something (value (HSV value) adjustment, texture, etc.) to ensure that log level is not coded in a way that is invisible to colour blind people. :)

@robertkowalski
Copy link
Member Author

@deathbearbrown can you give me some nice color values that help here? I would keep the log-level, but change the colors, that we are able to sort & search.

@robertkowalski
Copy link
Member Author

Closing this, as logs will disappear soon.

@robertkowalski robertkowalski deleted the 2135-remove-log-level branch May 23, 2014 18:24
nickva pushed a commit to cloudant/couchdb that referenced this pull request Apr 21, 2017
This closes apache#205

Signed-off-by: ILYA Khlopotov <iilyak@apache.org>
lag-linaro pushed a commit to lag-linaro/couchdb that referenced this pull request Oct 25, 2018
Adapt rebar_erlydtl_compiler to handle warnings emitted by
erlydtl:compile/3.
lag-linaro pushed a commit to lag-linaro/couchdb that referenced this pull request Oct 25, 2018
Fix apache#205 (erlydtl:compile/3 returns warnings)
janl added a commit that referenced this pull request Jan 5, 2020
nickva pushed a commit to nickva/couchdb that referenced this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants