Remove log level name from the log list & some styling fixes#205
Remove log level name from the log list & some styling fixes#205robertkowalski wants to merge 1 commit intoapache:masterfrom
Conversation
- Remove the message-level from the view - small columns (pid, date) get less width - padding around the view Closes COUCHDB-2135
|
Why would you remove log level? |
|
You can see the level by the color, so it might be redundant and @kxepal wants to remove it to save some more space. |
|
Lots of people are red-blue and red-green colour blind. -1. |
|
I am not colorblind, but with text I can use ctrl+f to search for errors. As I think there is some further discussion needed regarding that change I will slice off the style changes I made into a separate PR. |
|
Look at how Trello solve the colour blindness thing. You can enable optional "textures". |
|
I would prefer to keep loglevel. You can then filter on it. I would move the filter to above the table so that we have more width. We could remove the PID, not sure how helpful that is. |
|
RE: colorblindness I like art stuff, and wanted to comment because I happen to know about this stuff. >.> |
|
Sorry for the drive-by earlier. I agree with @deathbearbrown and @garrensmith here. Filtering on log level is useful, and CTRL+F to search row by row on the actual log level itself is useful. I don't want to give up either of those things. I'm neutral on styling preferences other than that we do something (value (HSV value) adjustment, texture, etc.) to ensure that log level is not coded in a way that is invisible to colour blind people. :) |
|
@deathbearbrown can you give me some nice color values that help here? I would keep the log-level, but change the colors, that we are able to sort & search. |
|
Closing this, as logs will disappear soon. |
This closes apache#205 Signed-off-by: ILYA Khlopotov <iilyak@apache.org>
Adapt rebar_erlydtl_compiler to handle warnings emitted by erlydtl:compile/3.
Fix apache#205 (erlydtl:compile/3 returns warnings)
Closes COUCHDB-2135
Preview:
