Skip to content

Fauxton: do not slice off the error text from erlang errors#207

Closed
robertkowalski wants to merge 1 commit intoapache:masterfrom
robertkowalski:logs-sliced-off
Closed

Fauxton: do not slice off the error text from erlang errors#207
robertkowalski wants to merge 1 commit intoapache:masterfrom
robertkowalski:logs-sliced-off

Conversation

@robertkowalski
Copy link
Member

As the erlang errors contain two linebreaks, and the parsing
function is using linebreaks to separate the messages, the content
was sliced off, which looked like there would not be enough space
for the message. In fact it got lost during the parsing.

This tries to normalize the data before and after the parsing,
it removes the linebreaks of the erlang errors so it is parsed
right. As the other spaces are no &nspb;-entities it does not hurt
that the are removed.

Before:
bildschirmfoto 2014-04-12 um 14 58 15

Now:
bildschirmfoto 2014-04-12 um 15 31 43

As the erlang errors contain two linebreaks, and the parsing
function is using linebreaks to separate the messages, the content
was sliced off, which looked like there would not be enough space
for the message. In fact it got lost during the parsing.

This tries to normalize the data before and after the parsing,
it removes the linebreaks of the erlang errors so it is parsed
right. As the other spaces are no &nspb;-entities it does not hurt
that the are removed.
@deathbearbrown
Copy link
Member

+1 :3

@garrensmith
Copy link
Member

+1 @robertkowalski, since you are a committer you can merge this in yourself :)

@robertkowalski
Copy link
Member Author

@deathbearbrown already merged for me, thank you! thanks for taking a look, highly appreciated! :)

@robertkowalski robertkowalski deleted the logs-sliced-off branch April 18, 2014 11:04
nickva pushed a commit to cloudant/couchdb that referenced this pull request Apr 21, 2017
This closes apache#207

Signed-off-by: ILYA Khlopotov <iilyak@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants