Fauxton: do not slice off the error text from erlang errors#207
Closed
robertkowalski wants to merge 1 commit intoapache:masterfrom
Closed
Fauxton: do not slice off the error text from erlang errors#207robertkowalski wants to merge 1 commit intoapache:masterfrom
robertkowalski wants to merge 1 commit intoapache:masterfrom
Conversation
As the erlang errors contain two linebreaks, and the parsing function is using linebreaks to separate the messages, the content was sliced off, which looked like there would not be enough space for the message. In fact it got lost during the parsing. This tries to normalize the data before and after the parsing, it removes the linebreaks of the erlang errors so it is parsed right. As the other spaces are no &nspb;-entities it does not hurt that the are removed.
Member
|
+1 :3 |
Member
|
+1 @robertkowalski, since you are a committer you can merge this in yourself :) |
Member
Author
|
@deathbearbrown already merged for me, thank you! thanks for taking a look, highly appreciated! :) |
nickva
pushed a commit
to cloudant/couchdb
that referenced
this pull request
Apr 21, 2017
This closes apache#207 Signed-off-by: ILYA Khlopotov <iilyak@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the erlang errors contain two linebreaks, and the parsing
function is using linebreaks to separate the messages, the content
was sliced off, which looked like there would not be enough space
for the message. In fact it got lost during the parsing.
This tries to normalize the data before and after the parsing,
it removes the linebreaks of the erlang errors so it is parsed
right. As the other spaces are no &nspb;-entities it does not hurt
that the are removed.
Before:

Now:
