Fauxton: fix missing leading zeros in logs #208
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
This looks good, as another option. Could we not use d3.timeFormat? https://github.com/mbostock/d3/wiki/Time-Formatting
Member
Author
There was a problem hiding this comment.
Awesome idea! Changed that!
This adds leading zeros to the times in the log view. Before that the times were displayed like 1:5:3 (if it were 01:05:03) because getHours() and friends are returning a Number and not a String with a leading 0. In the case of 1:5:3 the corrected time is now displayed as: 01:05:03. As d3 has a nice date formatter we do not have to roll our own.
Member
|
Thanks @robertkowalski, I have merged it. You can close this PR. |
lag-linaro
pushed a commit
to lag-linaro/couchdb
that referenced
this pull request
Oct 25, 2018
…mpiler Fix typo in rebar_erlydtl_compiler
janl
pushed a commit
that referenced
this pull request
Jan 5, 2020
* Edit for clarity, style * Make explicit mention of _config/_local
nickva
pushed a commit
to nickva/couchdb
that referenced
this pull request
Sep 7, 2022
* Edit for clarity, style * Make explicit mention of _config/_local
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds leading zeros to the times in the log view. Before that
the times were displayed like 1:5:3 (if it were 01:05:03)
because getHours() and friends are returning a Number and not
a String with a leading 0. In the case of 1:5:3 the corrected
time is now displayed as: 01:05:03