Group log messages by date - COUCHDB-2136#214
Closed
robertkowalski wants to merge 1 commit intoapache:masterfrom
Closed
Group log messages by date - COUCHDB-2136#214robertkowalski wants to merge 1 commit intoapache:masterfrom
robertkowalski wants to merge 1 commit intoapache:masterfrom
Conversation
Member
There was a problem hiding this comment.
I think it would make more sense for the collection have have this function than the view. The collection knows what data it holds. It would also make it easier to use this method elsewhere it we needed.
Member
|
Hey @robertkowalski, this looks great. Just some small comments. Once you have made those changes, you can merge it. |
Introduce a heading for each day in the logs and remove the day from each column. Closes COUCHDB-2136
Member
|
+1 looks great. Merge it |
Member
Author
|
Merged! |
lag-linaro
pushed a commit
to lag-linaro/couchdb
that referenced
this pull request
Oct 25, 2018
Document compile_only=true
janl
pushed a commit
that referenced
this pull request
Jan 5, 2020
* GET can return multipart/mixed or multipart/related
* Mention the possibility of multipart/related in the PUT /{doc} description
nickva
pushed a commit
to nickva/couchdb
that referenced
this pull request
Sep 7, 2022
* GET can return multipart/mixed or multipart/related
* Mention the possibility of multipart/related in the PUT /{doc} description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a heading for each day in the logs and remove the day
from each column.
Closes COUCHDB-2136
I also tested to hack the logic into the view, which would be around 20ms faster, but it wouldn't be testable and more logic in the views, which I want to avoid.