Merged
Conversation
willholley
force-pushed
the
mango_test_fixes
branch
2 times, most recently
from
b903db1 to
2c8983a
Compare
Member
|
@willholley this seems to break the tests. |
willholley
force-pushed
the
mango_test_fixes
branch
from
2c8983a to
4b7dae5
Compare
When creating a Mango index in the Elixir tests, we need to block until the database reports the index as available. This workaround was present in the python Mango tests but did not get ported to Elixir when the partitioned Mango tests were added. Presumambly this is needed to workaround an underlying race condition between the index write and the ddoc cache.
willholley
force-pushed
the
mango_test_fixes
branch
from
4b7dae5 to
5c0cf2e
Compare
willholley
changed the title
Member
Author
|
@garrensmith oops - should be okay now. I think this may still be needed in addition #2363 given the python-based Mango tests have always run with n=1 iirc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
When creating a Mango index in the Elixir tests, we need to block until the database reports the index as available. This workaround was present in the python Mango tests but did not
get ported to Elixir when the partitioned Mango tests were added.
Presumably this is needed to workaround an underlying race condition between the index write and the ddoc cache.
Testing recommendations
let's see if it reliably passes in CI...
Related Issues or Pull Requests
Checklist
rel/overlay/etc/default.ini