Closed
Conversation
5c85c3e to
aae193f
Compare
We sleep for a bit more than a second for each test. Rather than using return to skip a test we just mark the test as skipped so we don't have to waste time. This saves about 25s on the test suite.
The body of these tests were running during the setup phase which is not correct. Wrapping each body with `?_test()` macros fixes the issue.
The quiet and start periods of a second were costing quite a bit of time. Setting them to zero shaves off about 26 seconds.
This moves all of the mock work to a single setup function and then just resets all of the mocked modules before each test run.
Moving the meck configuration into setup and resetting in foreach makes tests quite a bit faster.
This just populates a single test db and then copies the raw file to a new database name for each individual test.
Another module where loading the meck expect values once per suite saves us 20s or so.
Another example of moving mocks to a setup and using `meck:reset/1` in the foreach fixture.
Another example of moving mocks around.
There's no need to call through mocked functions when we can just assert its the correct function returned.
Increase the doc write batch count in the background writer process to speed up the should_populate_and_compact test.
aae193f to
c7712ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Make tests faster
Testing recommendations
time make checkChecklist
rel/overlay/etc/default.ini