fix attachment view to bypass backbone processing#247
Closed
sebastianrothbucher wants to merge 1 commit intoapache:masterfrom
Closed
fix attachment view to bypass backbone processing#247sebastianrothbucher wants to merge 1 commit intoapache:masterfrom
sebastianrothbucher wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
Thank you! +1 |
Member
|
+1 |
Member
|
+1 thanks Sebastian :) looking forward to see more contributions by you :) |
Member
|
Landed as 4fbeff9 in master, you can close the PR now. |
janl
pushed a commit
that referenced
this pull request
Jan 5, 2020
* Grammar corrections * Edit for readability
nickva
pushed a commit
to nickva/couchdb
that referenced
this pull request
Sep 7, 2022
* Grammar corrections * Edit for readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did apply to the API URL a few days before also applies to viewing attachments: a data-bypass="true" needs to be added to the link pointing to an attachment. then it opens in a new window. Otherwise, an invalid URL to fauxton is constructed that goes nowhere. Test: add an attachment and try to view it