-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fauxton: Create fx roles #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fauxton auth works by checking what roles a user has and then decide if they have access to a specific route. The only problem is a regular user might get created but not have any roles. Unlike an admin user who get assigned all the roles on creation. The idea behind this is that certain routes should require a user to be logged in but not necessary have any roles eg. #changePassword route. This allows for a standard fauxton role that all logged in users get given so that we can check via the roles if they are logged
|
How about just |
|
I would prefer to prefix it so we can add other roles later if need be. |
|
I'd wouldn't be so optimistic since this mostly looks like a hack. But anyway, leading |
|
Also, am I right that you'd only fixed access to "Change Password" page? Because access to databases/replication still asks to log in (even if you're). |
|
Correct I haven’t added it to databases and replication yet. I can do that. I first wanted to get some opinions on this approach. Its not the prettiest approach but I don’t want to spend too much time on auth until the Big Couch merge is over. So this should be “good enough” for now. On 18 Jun 2014, at 4:44 PM, Alexander Shorin notifications@github.com wrote:
|
|
Errhm..I just read the |
|
The |
|
Will auth change with the BigCouch merge? |
|
@robertkowalski not auth, but set of default roles I believe. The code caused the issue was ported from Cloudant fork and it forces check user for some special roles. |
|
I think I am okay with it, I also have no better idea just now for a quick fix. |
|
Great thanks. Merged. |
The combination of changes to rebar_erlc_compiler, and the fact that erl_first_files is inherited, caused a regression. To fix that, ensure every project uses its own .rebar/erlcinfo. While at it, fix the issue that erl_first_files entries were not included when initializing the dep digraph. Reported-by: Louis-Philippe Gauthier Reported-by: Roland Karlsson Thanks: Tuncer Ayaz
Fix apache#249 (erlc regression)
Fauxton auth works by checking what roles a user has and then decide if
they have access to a specific route. The only problem is a regular user
might get created but not have any roles. Unlike an admin user who get
assigned all the roles on creation.
The idea behind this is that certain routes should require a user to be
logged in but not necessary have any roles eg. #changePassword route.
This allows for a standard fauxton role that all logged in users get given so that
we can check via the roles if they are logged