Port form_submit.js test to Elixir

[dottorblaster]

Overview

Ported form_submit js test to Elixir

Testing recommendations

Just issue make elixir

Related Issues or Pull Requests

None

Checklist

• Code is written and works correctly
• Changes are covered by tests
• Any new configurable parameters are documented in rel/overlay/etc/default.ini
• A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation

[jjrodrig]

Hi @dottorblaster

The test seems to be ok. Are you still working on it?

Please, remember to tag the form_submit.js as ported by adding the following line as the first line of the js test.

return console.log('done in test/elixir/test/form_summit_test.exs');

and mark it as done in test/elixir/README.md

Thanks!

[dottorblaster]

Hi @jjrodrig

Yeah it's still a WIP, I'm finalizing this PR right now, thanks for reviewing it in advance!

I'll do it in a separate commit and ask for a review once I've done, thanks for warning me out on that, I wasn't up to date abotu that return statement

[jjrodrig]

Please, don't forget to merge this also in 3.x branch
Thanks!

[wohali]

@jjrodrig @dottorblaster It should hit all of: master, 3.x and 3.0.x please. Sorry, I know that's a lot of work, but we are planning a 3.0.1 release in the next week or two, and it'd be nice to include these improvements there.

[dottorblaster]

@wohali @jjrodrig looks reasonable :-)

What's the workflow? Should I create new PRs for this branch to hit 3.x and 3.0.y, or should I cherry pick my commits from master to those branches?

[wohali]

Yes, 3 separate PRs required. Those other 2 branches are protected, you shouldn't be able to commit to them directly.

[dottorblaster]

@wohali going to do this in some time, thanks for showing me the way 😅