Skip to content

Port reader_acl test into elixir test suite#2969

Merged
jjrodrig merged 1 commit intoapache:masterfrom
jjrodrig:port-reader-acl
Jun 29, 2020
Merged

Port reader_acl test into elixir test suite#2969
jjrodrig merged 1 commit intoapache:masterfrom
jjrodrig:port-reader-acl

Conversation

@jjrodrig
Copy link
Copy Markdown
Contributor

Overview

This PR ports reader_acl.js test into the elixir test suite

Testing recommendations

make elixir tests=test/elixir/test/reader_acl_test.exs

Related Issues or Pull Requests

N/A

Checklist

  • Code is written and works correctly
  • Changes are covered by tests
  • Any new configurable parameters are documented in rel/overlay/etc/default.ini
  • A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation

@jjrodrig jjrodrig requested a review from dottorblaster June 29, 2020 13:31
Copy link
Copy Markdown
Member

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nice work!

@jjrodrig
Copy link
Copy Markdown
Contributor Author

@dottorblaster Thanks for the review!

@jjrodrig jjrodrig merged commit c6940d8 into apache:master Jun 29, 2020
@jjrodrig jjrodrig deleted the port-reader-acl branch October 16, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants