Fix auth injection in test helper#2985
Merged
iilyak merged 1 commit intoapache:prototype/fdb-layerfrom Jul 13, 2020
Merged
Conversation
Previously the auth was injected unconidtionally. There were two problems: 1. no way to specify `basic_auth` credentials 2. no way to disable injection Due to #2 it was impossible to use other user than hardcoded `adm` () in `Couch.login/3`.
jaydoane
approved these changes
Jul 10, 2020
Contributor
jaydoane
left a comment
jaydoane
left a comment
There was a problem hiding this comment.
LGTM & tests pass
make exunit tests=src/chttpd/test/exunit/pagination_test.exs
Finished in 24.2 seconds
133 tests, 0 failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Previously the auth was injected unconidtionally. There were two problems:
basic_authcredentialsDue to #2 it was impossible to use other user than hardcoded
adminCouch.login/3.Testing recommendations
The following should be sufficient to test for regressions
Related Issues or Pull Requests
Checklist
rel/overlay/etc/default.ini