Conversation
Add nodejs and npm for Fauxton
There was a problem hiding this comment.
I feel cold for blindly executing arbitrary shell script. Isn't there a more secure and explicit way to add those repository?
There was a problem hiding this comment.
+1, we should do what the script does directly, not download it first. It is MIT licensed, we could keep a local copy.
There was a problem hiding this comment.
Hello everyone,
Nice to have feed back :D.
I found it in http://nodejs.org/download/ there is a link "Installing from package managers" so I took it . I thought it was a good think.
Sorry if I did something wrong
We can also download the source and install manually if you want.
There was a problem hiding this comment.
@MCyprien you didn’t do anything wrong, no worries! :)
It’s just that we have to think about beyond just having someone interactively installing Node.js for CouchDB, hence our comments.
The best way forward would be to import the file as a dependency (needs an update in the NOTICE and LICENSE files) and then call it locally.
There was a problem hiding this comment.
or we could just borrow a few bits from https://github.com/klaemo/docker-couchdb/blob/master/2.0-dev/Dockerfile#L32-L35 if @klaemo doesn't mind (:
P.S. @janl, another question is a reason to maintain our Dockerfile when @klaemo keep his well. May be we could unite our effort on this with Clemens instead of doing the same work twice?
There was a problem hiding this comment.
#facepalm, that’s a great idea. — Let’s see if @klaemo is up for contributing his work :)
There was a problem hiding this comment.
|
This is being worked on in #340, so this PR can be closed, I'd say. |
Fix compiler invocation on multiarch Linux
document bionic availability
5 participants
Add nodejs and npm for Fauxton