Skip to content

Conversation

@bessbd
Copy link
Member

@bessbd bessbd commented Aug 28, 2020

This is a backport of master's 4240391 to 3.x.

To use multiple `drilldown` parameters users had to define
`drilldown` multiple times to be able supply them.

This caused interoperability issues as most languages require
defining query parameters and request bodies as associative
arrays, maps or dictionaries where the keys are unique.

This change enables defining `drilldown` as a list of lists so
that other languages can define multiple drilldown keys and values.

Co-authored-by: Robert Newson <rnewson@apache.org>
Copy link
Contributor

@iilyak iilyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wohali
Copy link
Member

wohali commented Aug 28, 2020

Hey @bessbd, thanks for the fixes (this and #3108). I think this may be the first time I've seen you here, but you do seem to already be an Apache committer.

Obviously you know what you're doing here, but @iilyak or I or someone else will have to merge these for you, I think, as I don't have any record of having put you in as a CouchDB committer.

@wohali wohali merged commit 39514bd into apache:3.x Aug 28, 2020
@bessbd
Copy link
Member Author

bessbd commented Aug 30, 2020

Thank you for the review, @iilyak !

@wohali : the original commits which I wanted to backport here and in #3108 were actually (at least partly) created by me, but it's always great to be noticed!

already be an Apache committer
any record of having put you in as a CouchDB committer

Right, I'm a member of Apache Flume and I'm not a CouchDB committer (yet, though I'm doing my best to become one someday).

Also, thank you for the merge, @wohali .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants