Skip to content

Conversation

@kxepal
Copy link
Member

@kxepal kxepal commented Apr 4, 2015

Since /_cluster_setup requires Admin Party to be fixed it's not suitable for running our JavaScript test suite which requires Admin Party to be on. So the old way to make a cluster is provided now as an option.

Also I a bit modified output to make it nicer and show all possible issues without making a look that it's hanged:

[ * ] Setup environment ... ok
[ * ] Ensure CouchDB is built ... ok
[ * ] Prepare configuration files ... ok
[ * ] Start node node1 ... ok
[ * ] Start node node2 ... ok
[ * ] Start node node3 ... ok
[ * ] Check node at http://127.0.0.1:15984/ ... failed: <urlopen error [Errno 111] Connection refused>
[ * ] Check node at http://127.0.0.1:25984/ ... failed: <urlopen error [Errno 111] Connection refused>
[ * ] Check node at http://127.0.0.1:35984/ ... ok
[ * ] Check node at http://127.0.0.1:15984/ ... ok
[ * ] Check node at http://127.0.0.1:25984/ ... ok
[ * ] Running cluster setup ... ok
[ * ] Developers cluster is set up at http://127.0.0.1:15984.
Admin username: root
Password: AaqFj+kO
Time to hack! ... 

cc @janl @robertkowalski

@robertkowalski
Copy link
Member

Cool idea! +1 on integrating cluster_setup more

Can we just use /_cluster_setup if the --admin flag was provided? this way we would not need the --with-admin-party-please flag, right?

I guess this would also solve possible issues with:

./dev/run --admin=foo:bar --with-admin-party-please

(which I haven't tested)

@kxepal
Copy link
Member Author

kxepal commented Apr 5, 2015

Good point about --admin and --with-admin-party-please conflict, but word please is much stronger and forces Admin Party to be applied (:

The problem is that 95% of users will not run this script with --admin parameter => dev/run will not use /_cluster_setup => users will not fix admin party => these cases will not be tested.

Since real cluster will always run with fixed Admin Party, we need to encourage uses to run dev cluster as well with no Admin Party, unless they explicitly want to not fix it. That is the idea I implemented here: if you didn't specify admin credentials, script generated them for you.

@asfgit asfgit merged commit 9f5ae10 into apache:master Apr 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants