Conversation
rnewson
force-pushed
the
fix-buffer-response-true
branch
3 times, most recently
from
15dd37a to
f6adde2
Compare
davisp
approved these changes
Sep 10, 2020
Member
davisp
left a comment
davisp
left a comment
There was a problem hiding this comment.
+1. Those multi-clause-anonymous-inline-functions are always kinda weird so whatever you feel like doing on that style suggestion is up to you.
src/chttpd/src/chttpd.erl
Outdated
Comment on lines
+865
to
+869
| lists:foreach( | ||
| fun | ||
| ("") -> ok; | ||
| (Chunk) -> send_chunk(Resp, Chunk) | ||
| end, lists:reverse(Chunks)), |
Member
There was a problem hiding this comment.
This formatting is kinda weird. Mebbe something like such?
lists:foreach(fun
([]) -> ok;
(Chunk) -> send_chunk(Resp, Chunk)
end, lists:reverse(Chunks)),
We need to call StartFun as it might add headers, etc.
rnewson
force-pushed
the
fix-buffer-response-true
branch
from
f6adde2 to
4b77c06
Compare
rnewson
added a commit
that referenced
this pull request
Sep 10, 2020
We need to call StartFun as it might add headers, etc.
rnewson
added a commit
that referenced
this pull request
Sep 10, 2020
rnewson
added a commit
that referenced
this pull request
Sep 11, 2020
We need to call StartFun as it might add headers, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to call StartFun as it might add headers, etc.