Verify correctness with concurrent updates #3413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickva
reviewed
Mar 10, 2021
Contributor
nickva
left a comment
nickva
left a comment
There was a problem hiding this comment.
I see it passes:
make elixir tests=test/elixir/test/concurrent_writes_test.exs
...
ConcurrentWritesTest
* test Primary data tests (1001.8ms)
* test Secondary data tests (5860.7ms)
I tried reverting ec4b213 and it still passed. Ideally, we'd want it to fail then. If you want let's merge this tests but if possible see if we can make it fail with another more complex test. I think the key to failure there was to have few view queries, such that he view would be forced to update a few times perhaps.
nickva
reviewed
Mar 10, 2021
| test "Primary data tests", context do | ||
| db_name = context[:db_name] | ||
| parent = self() | ||
| Enum.each(1..99, |
Contributor
There was a problem hiding this comment.
Minor nit: make 99 a variable at the top somewhere so we could make the test run with say 1000 or more docs if needed
Contributor
There was a problem hiding this comment.
Perhaps we can also assert that doc puts succeeded by checking
r = Couch.put("/#{db_name}/doc#{x}", body: %{:a => x})
assert r.status_code == 201
rnewson
force-pushed
the
concurrent_write_tests
branch
from
6de3cac to
c1c8295
Compare
Member
Author
|
Added nick's suggestions and his max_sessions work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Verify correct behaviour when a database is updated concurrently, particularly for secondary indexes.
Testing recommendations
N/A, these are just new tests.
Related Issues or Pull Requests
Motivated by #3382
Checklist
rel/overlay/etc/default.ini