Decrease the view indexer transaction time #3447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickva
force-pushed
the
decrease-indexer-transaction-time-limit
branch
from
d04b2fb to
e19587b
Compare
The indexer transaction time is decreased in order to allow enough time for the client to re-use the same GRV to emit doc bodies. This PR goes along with [1], where emitted doc bodies in a view responses now come from the same database read version as the one used by the indexer. Since the batcher previously used 4.5 seconds as the maximum, that left little time to read any doc bodies. [1]: #3391 Issue: #3381
nickva
force-pushed
the
decrease-indexer-transaction-time-limit
branch
from
e19587b to
aa800e2
Compare
kocolosk
approved these changes
Mar 23, 2021
Member
kocolosk
left a comment
kocolosk
left a comment
There was a problem hiding this comment.
Makes sense. Curious to see how sensitive indexing throughput is to some of these parameters, but I'd expect cutting the transaction time down to 1.5 seconds will not be an issue at all.
Contributor
Author
|
The default behavior was characterized by @davisp during the initial PR for the new batcher: #3127 (comment) During overload, especially if using a remote |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The indexer transaction time is decreased in order to allow enough time for the client to re-use the same GRV to emit doc bodies.
This PR goes along with another PR, where emitted doc bodies in a view responses now come from the same database read version as the one used by the indexer. Since the batcher previously used 4.5 seconds as the maximum, that left little time to read any doc bodies.
Issue: #3381