Fix git VSN on build release #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
+1 |
build-aux/couchdb-build-release.sh
Outdated
Member
There was a problem hiding this comment.
can we grab the actual value here? For users of couchdb 2.0, 2.1, etc, they won't see or care about these values, but other users, like Cloudant, will make releases that only change some applications, so showing the actual git value will help. Specifically, the output of git describe --always --tags within that directory.
Member
Author
There was a problem hiding this comment.
Sure. So: ${VERSION}-git describe --always --tags ?
Member
There was a problem hiding this comment.
hm, I think just the value of git describe --always --tags. the $VERSION value should be in the tarball file name and in the GET / welcome message.
Member
Author
Member
|
+1, we can always tidy later when inspiration strikes. |
This is what rebar will try to do on make for generated tarball, but it will because missed .git directories around.
Member
Author
|
Good. Landed. Thanks! |
janl
pushed a commit
that referenced
this pull request
Jan 5, 2020
nickva
pushed a commit
to nickva/couchdb
that referenced
this pull request
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.