Skip to content

Pr 3766#3877

Closed
nickva wants to merge 4 commits into3.xfrom
pr-3766
Closed

Pr 3766#3877
nickva wants to merge 4 commits into3.xfrom
pr-3766

Conversation

@nickva
Copy link
Copy Markdown
Contributor

@nickva nickva commented Dec 15, 2021

This is a draft PR to help @noahshaw11 reformat his PR with erlfmt

noahshaw11 and others added 4 commits December 15, 2021 18:33
Ended up fixing these two syntax errors:

```
diff --git a/src/smoosh/src/smoosh_priority_queue.erl b/src/smoosh/src/smoosh_priority_queue.erl
index 6492f02..6fcee55e3 100644
--- a/src/smoosh/src/smoosh_priority_queue.erl
+++ b/src/smoosh/src/smoosh_priority_queue.erl
@@ -76,7 +76,6 @@ in(Key, Value, Priority, Q) ->

 in(Key, Value, Priority, Capacity, #priority_queue{name=Name, map=Map, tree=Tree}) ->
     Tree1 = case maps:find(Key, Map) of
-        case dict:find(Key, Dict) of
             {ok, TreeKey} ->
                 gb_trees:delete_any(TreeKey, Tree);
             error ->
diff --git a/src/smoosh/src/smoosh_server.erl b/src/smoosh/src/smoosh_server.erl
index e89412f..9efeb06a1 100644
--- a/src/smoosh/src/smoosh_server.erl
+++ b/src/smoosh/src/smoosh_server.erl
@@ -181,7 +181,7 @@ handle_call(resume, _From, State) ->
         fun(#channel{name = Name, pid = P}, _) ->
             couch_log:notice("Resuming ~p", [Name]),
             smoosh_channel:resume(P)
-        end,
+        end, 0, State#state.tab),
     {reply, ok, State};

 handle_call({get_channel, ChannelName}, _From, #state{tab = Tab} = State) ->
```

So a careful audit for the changes should be done to make some semantic merge issues haven't snuck in.

Then ran `make erlfmt-format` again and it added all the other changes on top of that.
@nickva nickva closed this Dec 24, 2021
@nickva nickva deleted the pr-3766 branch December 24, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants