Remove ERL_OPTS

[noahshaw11]

Overview

Since Erlang 19.0 there is an ERL_COMPILER_OPTIONS environment variable which the compiler will consult.

Testing recommendations

Run make clean && ERL_COMPILER_OPTIONS='[no_line_info,deterministic,no_debug_info]' make.
Capture module-info from some module (something like couch_db:module_info(compile). perhaps). Then, run make clean && make and see if the changes took effect. With no_debug_info there should be almost no extra info shown.

Related Issues or Pull Requests

Remove ERL_OPTS handling from rebar.config* scripts: #3841

Checklist

• Code is written and works correctly
• Changes are covered by tests
• Any new configurable parameters are documented in rel/overlay/etc/default.ini
• A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation

[nickva]

To double-check if the compiler options work, try running

make clean && ERL_COMPILER_OPTIONS='[no_line_info,deterministic,no_debug_info]' make

Capture module info from some module (something like couch_db:module_info(compile). perhaps) then run make clean && make and see if the changes took effect. With no_debug_info there should be almost no extra info shown.

Also don't forget to update the Makefile{.win} files since reference ERL_OPTS there as well.

[noahshaw11]

To double-check if the compiler options work, try running

make clean && ERL_COMPILER_OPTIONS='[no_line_info,deterministic,no_debug_info]' make

Capture module info from some module (something like couch_db:module_info(compile). perhaps) then run make clean && make and see if the changes took effect. With no_debug_info there should be almost no extra info shown.

Also don't forget to update the Makefile{.win} files since reference ERL_OPTS there as well.

The compiler options are taking effect.

With compiler options:

(node1@127.0.0.1)1> couch_db:module_info(compile).
[{version,"7.6.7"}]

Without compiler options:

(node1@127.0.0.1)1> couch_db:module_info(compile).
[{version,"7.6.7"},
 {options,[debug_info,
           {d,'COUCHDB_VERSION',"3.2.1-48bfdcf"},
           {d,'COUCHDB_GIT_SHA',"48bfdcf"},
           {d,'COUCHDB_SPIDERMONKEY_VERSION',"1.8.5"},
           {i,"../"},
           {d,'WITH_PROPER'},
           {i,"include"}]},
 {source,"/Users/ncshaw/src/couchdb/src/couch/src/couch_db.erl"}]

[nickva]

+1

Works in main:

fabric2_db:module_info(compile).
[{version,"7.6.9.1"}]