Skip to content

Random bits of cleanup#3914

Merged
kocolosk merged 5 commits intomainfrom
random-bits-of-cleanup
Feb 1, 2022
Merged

Random bits of cleanup#3914
kocolosk merged 5 commits intomainfrom
random-bits-of-cleanup

Conversation

@kocolosk
Copy link
Copy Markdown
Member

Overview

I had forgotten to update mix.lock on a recent change to include support for Elixir v1.12, so that's included here. I also removed a few scripts that are leftovers from old build systems.

@kocolosk
Copy link
Copy Markdown
Member Author

Hah, looks like the build system expects a bin directory to exist, but I just removed all the version-controlled files from that directory. Will see if it makes sense to mkdir -p there.

Copy link
Copy Markdown
Contributor

@nickva nickva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

mkdir -p before copying rebar or other files or a .keep file in to handle bin would work, whichever looks better overall.

@kocolosk
Copy link
Copy Markdown
Member Author

Good thought on the .keep file, I added that for now. I feel like there's still some duplication and overlap between the bin/, build-aux/ and support/, but not going to try to resolve that here so taking the most conservative approach.

@kocolosk kocolosk merged commit 76fb5b9 into main Feb 1, 2022
@kocolosk kocolosk deleted the random-bits-of-cleanup branch February 1, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants