fix: consistent use of new config sections makes tests less flakey#3989
Closed
fix: consistent use of new config sections makes tests less flakey#3989
Conversation
Contributor
|
Closing this, superseeded and fixed by #4129. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happens is that CouchDB starts without a secret, auto-gens one as per usual and stores it at
[chttpd_auth] secretas per relatively recently, previously this was[couch_http_auth] secret.When that change happened, we added a utility fun reads
[chttpd_auth]and only falls back to[couch_http_auth]if no value exists.So when the test set
[couch_http_auth] secretit didn’t get picked up by CouchDB because the util function already found[chttpd_auth] secret.