Creating index with empty "name"/"ddoc" should return 400#3990
Merged
tonysun83 merged 1 commit intoapache:3.xfrom Apr 26, 2022
Merged
Creating index with empty "name"/"ddoc" should return 400#3990tonysun83 merged 1 commit intoapache:3.xfrom
tonysun83 merged 1 commit intoapache:3.xfrom
Conversation
jiahuili430
changed the title
jiahuili430
force-pushed
the
1472-fix-index-with-empty-ddoc
branch
4 times, most recently
from
e1895d5 to
cfe8979
Compare
iilyak
reviewed
Apr 14, 2022
jiahuili430
force-pushed
the
1472-fix-index-with-empty-ddoc
branch
2 times, most recently
from
8067cb0 to
f944fb2
Compare
jiahuili430
changed the title
jiahuili430
changed the title
jiahuili430
force-pushed
the
1472-fix-index-with-empty-ddoc
branch
3 times, most recently
from
5a6cf78 to
ea79831
Compare
tonysun83
reviewed
Apr 22, 2022
tonysun83
reviewed
Apr 22, 2022
jiahuili430
force-pushed
the
1472-fix-index-with-empty-ddoc
branch
from
ea79831 to
0e36eef
Compare
tonysun83
approved these changes
Apr 23, 2022
jiahuili430
force-pushed
the
1472-fix-index-with-empty-ddoc
branch
2 times, most recently
from
0bd7d44 to
1cd0d12
Compare
Creating an index with "ddoc":"" or "name":"" should return a 400 Bad Request.
Testing recommendations:
```
curl -X DELETE $db/abc && curl -X PUT $db/abc
curl -X POST $db/abc/_index -H 'Content-Type: application/json' -d '{"ddoc": "", "index": {"fields": ["foo"]}}'
curl -X POST $db/abc/_index -H 'Content-Type: application/json' -d '{"name": "", "index": {"fields": ["bar"]}}'
{"error":"invalid_empty_string","reason":"Index name/ddoc cannot be empty"}
```
Related Issues: apache#1472
jiahuili430
force-pushed
the
1472-fix-index-with-empty-ddoc
branch
from
1cd0d12 to
f714678
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Creating an index with
"ddoc":""or"name":""should return a400 Bad Request.Testing recommendations
Related Issues or Pull Requests
#1472
Checklist
rel/overlay/etc/default.ini