Merged
Conversation
* Refactor lag logging to a separate function. * When purge client validity throws an error log the error as well. * Use the newer `erlang:system_time(second)` call to get time. * When warning about update lag, log both the lag and the limit. * Add a specific log message if update timestamp is invalid. * Clarify that an invalid is not always because of a malformed checkpoint document. The most likely case is it's a stale view client checkpoint which hasn't been cleaned up properly. Fix: #4181
nickva
force-pushed
the
clean-up-purge-client-check-logging
branch
from
62fbcca to
6522728
Compare
janl
approved these changes
Nov 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve purge client cleanup logging
Refactor lag logging to a separate function.
When purge client validity throws an error log the error as well.
Use the newer
erlang:system_time(second)call to get time.When warning about update lag, log both the lag and the limit.
Add a specific log message if update timestamp is invalid.
Clarify that an invalid checkpoint is not always because of a malformed
checkpoint document. The most likely case is it's a stale view client
checkpoint which hasn't been cleaned up properly.
Fix: #4181