Allow _local doc writes to the replicator dbs#4416
Merged
Conversation
During the VDU -> BDU update we inadvertently blocked _local doc writes to _replicator dbs. This commit rectifies that. Add tests for _local, _design, and regular malformed docs for both the default _replicator db as well for for the prefixed version like $db/_replicator. For completeness, update the _scheduler/docs counts test also test both cases.
nickva
force-pushed
the
allow-local-docs-in-replicator-dbs
branch
from
9a3c0ac to
2d7038e
Compare
jaydoane
approved these changes
Feb 7, 2023
Contributor
jaydoane
left a comment
jaydoane
left a comment
There was a problem hiding this comment.
New tests look good 👍
module 'couch_replicator_scheduler_docs_tests'
couch_replicator_scheduler_docs_tests:53: -scheduler_docs_test_main_db_test_/0-fun-0- (t_scheduler_docs_total_rows)...[5.227 s] ok
couch_replicator_scheduler_docs_tests:63: -scheduler_docs_test_prefixed_db_test_/0-fun-0- (t_scheduler_docs_total_rows)...[5.083 s] ok
couch_replicator_scheduler_docs_tests:97: -with/1-fun-0- (t_local_docs_can_be_written)...[0.016 s] ok
couch_replicator_scheduler_docs_tests:97: -with/1-fun-0- (t_design_docs_can_be_written)...[0.014 s] ok
couch_replicator_scheduler_docs_tests:97: -with/1-fun-0- (t_malformed_docs_are_rejected)...[0.010 s] ok
couch_replicator_scheduler_docs_tests:97: -with/1-fun-0- (t_local_docs_can_be_written)...[0.029 s] ok
couch_replicator_scheduler_docs_tests:97: -with/1-fun-0- (t_design_docs_can_be_written)...[0.125 s] ok
couch_replicator_scheduler_docs_tests:97: -with/1-fun-0- (t_malformed_docs_are_rejected)...[0.012 s] ok
[done in 11.746 s]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the VDU -> BDU update we inadvertently blocked _local doc writes to _replicator dbs. This commit rectifies that.
Add tests for _local, _design, and regular malformed docs for both the default _replicator db as well for for the prefixed version like $db/_replicator. For completeness, update the _scheduler/docs counts test also test both cases.