Skip to content

Conversation

@vmx
Copy link
Contributor

@vmx vmx commented Mar 10, 2013

When attachments were returned (?attachments=true) while CORS was
enabled and used, an error occured. The reason for this error
were headers that were encoded as binaries instead of lists. String
operations on binaries throw errors.

This commit fixes COUCHDB-1689.

When attachments were returned (?attachments=true) while CORS was
enabled and used, an error occured. The reason for this error
were headers that were encoded as binaries instead of lists. String
operations on binaries throw errors.

This commit fixes COUCHDB-1689.
@rnewson
Copy link
Member

rnewson commented Mar 10, 2013

We prefer binaries to lists, is there a fix for this that goes the other way?

@vmx
Copy link
Contributor Author

vmx commented Mar 10, 2013

@rnewson That's not true. When headers are used with CORS they always only work with lists, not binaries.

Of course the code base could be changed so that all headers use binaries and CORS always converts the binaries to lists. But that's not the point of this patch :)

@rnewson
Copy link
Member

rnewson commented Mar 10, 2013

I understand the point of the patch, I'm just saying that if we are trying to fix this mismatch we prefer binaries over lists. If that's a much uglier patch (or even impossible) fair enough.

@vmx
Copy link
Contributor Author

vmx commented Mar 10, 2013

Now I got the point. I fear to break something with changing the headers from lists to binaries. From the source it looked like lists were preferred. So I would go with this patch and make it properly once we the whole HTTP layer gets cleanup/rewritten.

@rnewson
Copy link
Member

rnewson commented Mar 10, 2013

sounds good.

@rnewson
Copy link
Member

rnewson commented Mar 10, 2013

merged, thanks! please to close pull, yah?

@vmx
Copy link
Contributor Author

vmx commented Mar 10, 2013

Thanks for merging so quickly.

@vmx vmx closed this Mar 10, 2013
lag-linaro pushed a commit to lag-linaro/couchdb that referenced this pull request Oct 25, 2018
rebar_eunit:reset_after_eunit/1 mustn't remove 'included_applications'
kocolosk pushed a commit to kocolosk/couchdb that referenced this pull request May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants