Merged
Conversation
Contributor
|
+1 from me as well. I have tested the changes with Elixir 1.14.5 and 1.15.4 and there was no problem. Thank you! |
pgj
approved these changes
Aug 15, 2023
Contributor
Author
Contributor
|
Thanks for fixing it @jjrodrig! I did notice in the last main full CI build for .deb packages failed to build with this error: It mentions hex so was wondering if it's related perhaps to this PR. I'll try to re-run the CI build again to see if fails in the same way. |
nickva
pushed a commit
that referenced
this pull request
Nov 24, 2023
* Unlock support for Elixir 1.15 builds * Include elixir build folders into the make clean target
nickva
pushed a commit
that referenced
this pull request
Nov 27, 2023
* Unlock support for Elixir 1.15 builds * Include elixir build folders into the make clean target
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Elixir 1.5 introduces some changes in the compilation process tha affects to the execution of our test suite. The problem has been reported here #4706
It seems that we are facing one of the incompatibility problems documented in the Elixir 1.15 release notes
Previous to this PR, if we try to run the elixir test suite with Elixir 1.15, the following error appears in any test that uses
jiffy.This PR indroduces the suggested temporary fix in the
mix.exsby addingprune_code_paths: falseto the build config. With this change we can use Elixir 1.15 in our build process. I've tried to find the problem with our dependency declaration without sucess. This should be a temporary solution until we find the root of the problem.This PR introduces a second change in the Makefile clean target by adding aditional cleanup for elixir build artifacts.
Testing recommendations
make clean couch elixirThe elixir test suite should run without problems. Then check the cleanup.
make cleanfind . -name "_build"(No _build folder should be found)MIX_ENV=integration mix deps(should inform that every dependency needs to be compiled/updated)Related Issues or Pull Requests
This PR proposes a temporary solution for #4706
Checklist
rel/overlay/etc/default.inisrc/docsfolder