fix(mango): align opts.fields with fields on _explain#4756
Merged
pgj merged 1 commit intoapache:mainfrom Sep 12, 2023
Merged
Conversation
pgj
force-pushed
the
fix/mango/explain-opts_fields
branch
from
226534e to
ee47a38
Compare
This is a follow-up to 83e39b6 where the `all_fields` value was replaced for `[]` to preserve the JSON array type. The same has to be done for `fields` in the `opts` nesting object as well -- these two attributes should behave alike.
pgj
force-pushed
the
fix/mango/explain-opts_fields
branch
from
ee47a38 to
c478955
Compare
nickva
approved these changes
Sep 11, 2023
Contributor
nickva
left a comment
nickva
left a comment
There was a problem hiding this comment.
+1 good catch, we might as well stay consistent.
all_fields is not an explicit option users pass in to be worth preserving "as-is" for debugging purposes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to 83e39b6 where the
all_fieldsvalue was replaced for[]to preserve the JSON array type. The same has to be done forfieldsin theoptsnesting object as well — these two attributes should behave alike.Testing recommendations
Similarly to #4751, users who based their solution on utilizing the
"all_fields"response explicitly might need to change it to use[]instead. Otherwise they are not affected by the change.Checklist