Remove replication job supervisor#5036
Merged
Merged
Conversation
nickva
commented
Apr 24, 2024
| @@ -1,34 +0,0 @@ | |||
| % Licensed under the Apache License, Version 2.0 (the "License"); you may not | |||
Contributor
Author
There was a problem hiding this comment.
This is a left-over supervisor from many years ago when we switched to the scheduling replicator and forgot to remove it. Since we're cleaning up supervisors, removing the extra junk as well.
rnewson
approved these changes
Apr 24, 2024
Member
rnewson
left a comment
rnewson
left a comment
There was a problem hiding this comment.
a nice reduction in complexity.
nickva
force-pushed
the
prevent-local-duplicate-jobs-error
branch
from
aa5c5c8 to
b90a591
Compare
Use the scheduler as the job supervisor, since the scheduler is already a fancy supervisor, with its own backoff logic, process monitoring, etc. This simplifies the job starting/stopping logic and fixes a bug where the simple_one_for_one supervisor could restart a job, but the scheduler would consider it not running, and try to start another job with the same replication ID on the same node. Since jobs register themselves in pg, the second job would keep crashing with duplicate_job error the first time it tried to checkpoint.
nickva
force-pushed
the
prevent-local-duplicate-jobs-error
branch
from
b90a591 to
770faed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the scheduler as the job supervisor, since the scheduler is already a fancy supervisor, with its own backoff logic, process monitoring, etc.
This simplifies the job starting/stopping logic and fixes a bug where the simple_one_for_one supervisor could restart a job, but the scheduler would consider it not running, and try to start another job with the same replication ID on the same node. Since jobs register themselves in pg, the second job would keep crashing with duplicate_job error the first time it tried to checkpoint.