Skip to content

Enable tail call optimization in couch_replicator_docs #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nickva wants to merge 1 commit into from
Closed

Enable tail call optimization in couch_replicator_docs #505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions src/couch_replicator/src/couch_replicator_docs.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,19 +305,25 @@ update_rep_doc(RepDbName, RepDocId, KVs) ->


update_rep_doc(RepDbName, RepDocId, KVs, Wait) when is_binary(RepDocId) ->
try
case open_rep_doc(RepDbName, RepDocId) of
{ok, LastRepDoc} ->
update_rep_doc(RepDbName, LastRepDoc, KVs, Wait * 2);
_ ->
ok
end
catch
throw:conflict ->
Result = case open_rep_doc(RepDbName, RepDocId) of
{ok, LastRepDoc} ->
try
update_rep_doc(RepDbName, LastRepDoc, KVs, Wait * 2)
catch
throw:conflict ->
{error, conflict}
end;
_ ->
ok
end,
case Result of
{error, conflict} -> % Handle it here to enable tail call optimization
Msg = "Conflict when updating replication doc `~s`. Retrying.",
couch_log:error(Msg, [RepDocId]),
ok = timer:sleep(random:uniform(erlang:min(128, Wait)) * 100),
update_rep_doc(RepDbName, RepDocId, KVs, Wait * 2)
update_rep_doc(RepDbName, RepDocId, KVs, Wait * 2);
Result ->
Result
end;

update_rep_doc(RepDbName, #doc{body = {RepDocBody}} = RepDoc, KVs, _Try) ->
Expand Down