don't crash nouveau_index_updater for any DOWN Reason#5092
Merged
Conversation
rnewson
force-pushed
the
nouveau-manager-crash-fix
branch
from
8479746 to
316e931
Compare
nickva
approved these changes
Jun 18, 2024
Hard to induce in a unit test but under stress it is possible to get back
Reason's like `{timeout, {gen_server, call, ...` among others. Pass these
along to the client processes and do not crash the manager.
rnewson
force-pushed
the
nouveau-manager-crash-fix
branch
from
316e931 to
03f2f1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hard to induce in a unit test but under stress it is possible to get back Reason's like
{timeout, {gen_server, call, ...among others. Pass these along to the client processes and do not crash the manager.With this patch we log anything that wasn't
okbut always reply with whateverReasonwas so clients aren't left waiting.