Merged
Conversation
We close the lru via make_room/2 only. Nothing seems to call gen_server call, so let's not keep it around as it's confusing when inspecting the already tricky lru cache logic.
jiahuili430
approved these changes
Aug 3, 2024
Contributor
jiahuili430
left a comment
jiahuili430
left a comment
There was a problem hiding this comment.
+1
$ make eunit apps=couch
=======================================================
All 1405 tests passed.
Cover analysis: /Users/jiahuili/src/a/src/couch/.eunit/index.html
Code Coverage:
chttpd_endpoints_tests : 100%
couch : 0%
couch_app : 62%
couch_att : 81%
couch_auth_cache : 65%
couch_base32 : 96%
couch_bt_engine : 84%
couch_bt_engine_compactor : 91%
couch_bt_engine_compactor_ev : 87%
couch_bt_engine_header : 85%
couch_bt_engine_stream : 88%
couch_bt_engine_upgrade_tests : 100%
couch_btree : 89%
couch_changes : 82%
couch_compress : 90%
couch_db : 79%
couch_db_doc_tests : 100%
couch_db_engine : 81%
couch_db_epi : 100%
couch_db_mpr_tests : 100%
couch_db_plugin : 96%
couch_db_props_upgrade_tests : 100%
couch_db_split : 69%
couch_db_updater : 77%
couch_debug : 28%
couch_disk_monitor : 96%
couch_doc : 85%
couch_doc_json_tests : 97%
couch_ejson_compare : 77%
couch_ejson_size : 90%
couch_emsort : 91%
couch_etag_tests : 100%
couch_event_sup : 55%
couch_file : 84%
couch_flags : 70%
couch_flags_config : 89%
couch_hash : 100%
couch_hash_test : 100%
couch_hotp : 85%
couch_httpd : 59%
couch_httpd_auth : 43%
couch_httpd_db : 51%
couch_httpd_handlers : 100%
couch_httpd_misc_handlers : 3%
couch_httpd_multipart : 61%
couch_httpd_rewrite : 42%
couch_httpd_vhost : 83%
couch_hyper : 100%
couch_index_tests : 96%
couch_js_tests : 97%
couch_key_tree : 95%
couch_key_tree_prop_tests : 89%
couch_lru : 68%
couch_multidb_changes : 98%
couch_native_process : 36%
couch_os_process : 67%
couch_partition : 7%
couch_password_hasher : 62%
couch_passwords : 45%
couch_passwords_cache : 83%
couch_primary_sup : 100%
couch_proc_manager : 87%
couch_query_servers : 67%
couch_rand : 100%
couch_secondary_sup : 88%
couch_server : 71%
couch_stream : 91%
couch_sup : 52%
couch_task_status : 86%
couch_totp : 100%
couch_users_db : 18%
couch_util : 60%
couch_uuids : 90%
couch_work_queue : 79%
couchdb_attachments_tests : 99%
couchdb_auth_tests : 97%
couchdb_cookie_domain_tests : 100%
couchdb_cors_tests : 100%
couchdb_db_tests : 89%
couchdb_design_doc_tests : 100%
couchdb_file_compression_tests : 99%
couchdb_location_header_tests : 100%
couchdb_mrview_cors_tests : 100%
couchdb_mrview_tests : 99%
couchdb_open_doc_revs_tests : 100%
couchdb_os_proc_pool : 96%
couchdb_update_conflicts_tests : 98%
couchdb_vhosts_tests : 87%
couchdb_views_tests : 95%
global_changes_tests : 98%
json_stream_parse_tests : 100%
same_site_cookie_tests : 100%
test_request : 57%
test_util : 67%
test_web : 0%
Total : 78%
==> rel (eunit)
==> a (eunit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We close the lru via make_room/2 only. Nothing seems to call gen_server call, so let's not keep it around as it's confusing when inspecting the already tricky lru cache logic.