Skip validation for ddocs in the scanner #5331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if users had invalid ddocs in the cluster, for instance something
like `_design/`, the scanner would crash when tranforming them into `#doc{}`
records. That happened because the `couch_doc` function would automatically
revalidate them: check max doc length ID, attachments format, revision format,
doc ID format, etc. Which altogether silly, since they are already saved in our
cluster.
So, to avoid wasting resources revalidating existing documents, and crashing
the scanner process, use a much simpler function to transform the ddocs: make a
new `#doc{}` record with the ID and body by throwing away all the "special" doc
fields we don't care about (`_rev`, `_conflicts`, ...).
jaydoane
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if users had invalid ddocs in the cluster, for instance something like
_design/, the scanner would crash when transforming them into#doc{}records. That happened because thecouch_docfunction would automatically revalidate them: check max doc length ID, attachments format, revision format, doc ID format, etc. Which is altogether silly, since they are already saved in our cluster.So, to avoid wasting resources revalidating existing documents, and crashing the scanner process, use a much simpler function to transform the ddocs: make a new
#doc{}record with the ID and body by throwing away all the "special" doc fields we don't care about (_rev,_conflicts, ...).