Add a version check to clouseau connected() function #5417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickva
force-pushed
the
add-version-to-clouseau-ping
branch
2 times, most recently
from
cf546d2 to
d576d83
Compare
A ping is not enough. A clouseau instance is not usable if we it's just connected, it's main process should be up and running as well. We have observed that it is possible for the clouseau node to be connected and respond to pings, but the main process was down. We want to alert or catch cases when that happens so we ask the main process for the version.
nickva
force-pushed
the
add-version-to-clouseau-ping
branch
from
d576d83 to
f09da22
Compare
jaydoane
approved these changes
Jan 28, 2025
Contributor
jaydoane
left a comment
jaydoane
left a comment
There was a problem hiding this comment.
Tested against Clouseau 2.24
(node1@127.0.0.1)6> clouseau_rpc:connected().
true
| % {'EXIT',noconnection} | ||
| % | ||
| case (catch version()) of | ||
| {ok, _} -> true; |
Contributor
There was a problem hiding this comment.
Haha was just trying to suggest that change and you beat me to it!
Contributor
Author
There was a problem hiding this comment.
You did suggest it in the meeting, so thanks for your input, Jay!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A ping is not enough. A clouseau instance is not usable if we it's just connected, it's main process should be up and running as well.
We have observed that it is possible for the clouseau node to be connected and respond to pings, but the main process was down. We want to alert or catch cases when that happens so we ask the main process for the version.